IV/EV Info on Summary Screen #6027
Open
+436
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsd/pokeemerald-expansion-kaya into rhh-upcoming_ivs_on_stat_page
…expansion into rhh-upcoming_ivs_on_stat_page
…expansion into rhh-upcoming_ivs_on_stat_page
…expansion into rhh-upcoming_ivs_on_stat_page
…date comment accordingly
…expansion into rhh-upcoming_ivs_on_stat_page
…expansion into rhh-upcoming_ivs_on_stat_page
…hanging mons, and added options for only showing IVs or only showing EVs
…expansion into rhh-upcoming_ivs_on_stat_page
… bulbapedia page.
…expansion into rhh-upcoming_ivs_on_stat_page
AlexOn1ine
reviewed
Jan 18, 2025
Comment on lines
+2123
to
+2124
| else | ||
| ShowUtilityPrompt(SUMMARY_MODE_NORMAL); |
There was a problem hiding this comment.
Suggested change
| else | |
| ShowUtilityPrompt(SUMMARY_MODE_NORMAL); | |
| else | |
| { | |
| ShowUtilityPrompt(SUMMARY_MODE_NORMAL); | |
| } |
src/pokemon_summary_screen.c
Outdated
Comment on lines
4670
to
4672
| else if (P_SUMMARY_SCREEN_IV_EV_BOX_ONLY == FALSE) { | ||
| return (P_SUMMARY_SCREEN_IV_EV_INFO == TRUE || FlagGet(P_FLAG_IV_EV_INFO)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| else if (P_SUMMARY_SCREEN_IV_EV_BOX_ONLY == FALSE) { | |
| return (P_SUMMARY_SCREEN_IV_EV_INFO == TRUE || FlagGet(P_FLAG_IV_EV_INFO)); | |
| } | |
| else if (P_SUMMARY_SCREEN_IV_EV_BOX_ONLY == FALSE) | |
| { | |
| return (P_SUMMARY_SCREEN_IV_EV_INFO == TRUE || FlagGet(P_FLAG_IV_EV_INFO)); | |
| } |
There was a problem hiding this comment.
actually i could remove the brackets from this too
Comment on lines
+4673
to
+4674
| else | ||
| return FALSE; |
There was a problem hiding this comment.
Suggested change
| else | |
| return FALSE; | |
| else | |
| { | |
| return FALSE; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting to enable viewing IVs and EVs in the Summary Screen.
Description
PSS_LABEL_WINDOW_PROMPT_CANCELwindow to be a general-purpose utility prompt window, with logic implemented to display the correct prompt on each page. this takes over forPSS_LABEL_WINDOW_PROMPT_RENAME,PSS_LABEL_WINDOW_PROMPT_INFO, andPSS_LABEL_WINDOW_PROMPT_SWITCHas well.src/graphics.cthat only loads the alternate tileset when the setting is enabled.ChangeStatLabel(),ClearStatLabel(), andWriteToStatsTilemapBuffer()to control which label gets shown for each set of data.PutWindowTilemap()andClearWindowTilemap()for the utility prompt when not needed/handled by other code.SUMMARY_SKILLS_MODE_STATS, SUMMARY_SKILLS_MODE_IVS, SUMMARY_SKILLS_MODE_EVSas different modes for newPokemonSummaryScreenDatamembersMonSummaryScreen->skillsPageMode.ShowUtilityPrompt()andClearUtilityPrompt().ShowUtilityPrompt()takes an argument to illustrate what it's doing.Configurable options:
Images
People who collaborated with me in this PR
Discord contact info and PR thread